Skip to content

Conversation

@Ozzy-ZY
Copy link
Contributor

@Ozzy-ZY Ozzy-ZY commented Apr 16, 2024

added to Methods to the SinglyLinkedList (DeleteFirst, DeleteLast)

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
Ozzy-ZY and others added 3 commits April 15, 2024 17:24
I did this because the bitwise operations maybe not very readable specially for beginners
… added new tests for them in the LinkedListTests.cs
@Ozzy-ZY Ozzy-ZY requested a review from siriak as a code owner April 16, 2024 00:32
Ozzy-ZY and others added 2 commits April 17, 2024 23:36
Copy link
Contributor Author

@Ozzy-ZY Ozzy-ZY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied the suggestions provided by @siriak

@Ozzy-ZY Ozzy-ZY requested a review from siriak April 17, 2024 21:50
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check your indentation, but everything else looks good

@Ozzy-ZY Ozzy-ZY requested a review from siriak April 18, 2024 15:31
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f32c043 into TheAlgorithms:master Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants