Skip to content

Conversation

@Ozzy-ZY
Copy link
Contributor

@Ozzy-ZY Ozzy-ZY commented Apr 15, 2024

I did this because the bitwise operations maybe not very readable specially for beginners

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
I did this because the bitwise operations maybe not very readable specially for beginners
@Ozzy-ZY Ozzy-ZY requested a review from siriak as a code owner April 15, 2024 15:27
@siriak
Copy link
Member

siriak commented Apr 15, 2024

I think that in this case the bitwise operations are pretty simple, we are just taking half of the bits. While it's true that absolute beginners might not know about how bitwise operations work, but they might also not know how BitConverter works. The approach with BitConverter seems more complicated to me, so I prefer to leave bit operations in place here. Besides, there are more complicated bitwise operations in this file, so the reader must understand them anyway.

@siriak siriak closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants