Skip to content

Conversation

@SureshRepos
Copy link
Contributor

@SureshRepos SureshRepos commented Feb 3, 2024

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
@SureshRepos SureshRepos requested a review from siriak as a code owner February 3, 2024 19:18
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why build fails. You also need to make corresponding changes to application code.

@SureshRepos
Copy link
Contributor Author

All tests passed successfully!

@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd7d7fb) 94.91% compared to head (fb24275) 94.94%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #446 +/- ## ========================================== + Coverage 94.91% 94.94% +0.03%  ========================================== Files 234 234 Lines 9843 9843 Branches 1382 1382 ========================================== + Hits 9342 9345 +3  + Misses 386 384 -2  + Partials 115 114 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak
Copy link
Member

siriak commented Feb 4, 2024

Good. You need to remove commented out code as Codacy suggests

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) February 5, 2024 10:25
@siriak siriak merged commit 4f10a49 into TheAlgorithms:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants