Skip to content

Conversation

@gmottajr
Copy link
Contributor

Project Algorithms
Could not update Systems.Drawing.Common because that would cause lots os side effects that I believe it must require the maintainer project decisions make.
Issue 425 - Migrate to DotNet 8

Motivation and Context
Github issue #425: Proposed to Migrate to DotNet 8 and then update dependencies. It was requested to perform the changes in a few PRs to make them smaller and easier to review. This is the one only meant to update dependencies.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
Could not update Systems.Drawing.Common because that would cause lots os side effects that I believe it must require the maintainer project decisions make.
@gmottajr gmottajr requested a review from siriak as a code owner January 13, 2024 20:09
@codecov
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60a8513) 94.50% compared to head (90b7cc0) 94.51%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #440 +/- ## ========================================== + Coverage 94.50% 94.51% +0.01%  ========================================== Files 234 234 Lines 9843 9843 Branches 1455 1455 ========================================== + Hits 9302 9303 +1  Misses 381 381 + Partials 160 159 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak
Copy link
Member

siriak commented Jan 15, 2024

Sorry, maybe I'm not following, but what's the point of adding these packages? It seems to work fine without them

@gmottajr
Copy link
Contributor Author

You are correct, this is not what I meant actually. I'm closing this PR.

@gmottajr gmottajr closed this Jan 15, 2024
@gmottajr
Copy link
Contributor Author

Anyway I need to talk to you, @siriak ,about the update of the System.Drawing.Common nuget library. That version is deprecated and when you try to update it it causes lots of colateral effects.

@siriak
Copy link
Member

siriak commented Jan 15, 2024

Sure, can you start a thread in Discord?

@siriak
Copy link
Member

siriak commented Jan 21, 2024

I have created an issue to discuss that. See #441.

@gmottajr
Copy link
Contributor Author

Yeah, I use Discord. How can I find you, or your server, in there, @siriak?

@siriak
Copy link
Member

siriak commented Jan 21, 2024

Here is TheAlgorithms server https://discord.gg/c7MnfGFGa6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants