Skip to content

Conversation

@gmottajr
Copy link
Contributor

Project Algorithms.Tests

Switch to file-scoped namespaces
Issue 425 - Migrate to DotNet 8

Problems
Search
Sequences
Shufflers
Sorters
Strings

Motivation and Context

Github issue #425: Proposed to update to File-scoped namespaces. It was requested to perform the changes in a few PRs to make them smaller and easier to review.
This is the one final about only meant to Switch to file-scoped namespaces of the project AlgorithmsTests.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
Switch to file-scoped namespaces Issue 425 - Migrate to DotNet 8 Problems Search Sequences Shufflers Sorters Strings
@gmottajr gmottajr requested a review from siriak as a code owner January 11, 2024 06:06
@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b9c5b6) 94.50% compared to head (b20e697) 94.51%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #439 +/- ## ========================================== + Coverage 94.50% 94.51% +0.01%  ========================================== Files 234 234 Lines 9843 9843 Branches 1455 1455 ========================================== + Hits 9302 9303 +1  Misses 381 381 + Partials 160 159 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 60a8513 into TheAlgorithms:master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants