Skip to content

Conversation

@gmottajr
Copy link
Contributor

@gmottajr gmottajr commented Jan 9, 2024

Project DataStructures.Tests

Switch to file-scoped namespaces
Issue 425 - Migrate to DotNet 8

Motivation and Context
Github issue #425: Proposed to update to File-scoped namespaces. It was requested to perform the changes in a few PRs to make them smaller and easier to review. This is the one only meant to Switch to file-scoped namespaces of the project DataStructures.Tests.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
Switch to file-scoped namespaces Issue 425
@gmottajr gmottajr requested a review from siriak as a code owner January 9, 2024 14:46
@codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8ca3f4) 94.50% compared to head (2e20e1b) 94.41%.

Additional details and impacted files
@@ Coverage Diff @@ ## master #436 +/- ## ========================================== - Coverage 94.50% 94.41% -0.10%  ========================================== Files 234 234 Lines 9843 9843 Branches 1455 1455 ========================================== - Hits 9302 9293 -9  - Misses 381 387 +6  - Partials 160 163 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit d79e725 into TheAlgorithms:master Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants