Skip to content

Conversation

@gmottajr
Copy link
Contributor

Issue 425 - Migrate to DotNet 8 - File-scoped namespaces: Algorithms, Other, Problems, Search

Please let me know whether or not it would be necessary to create new unit tests for this change.

Motivation and Context
Github issue #425: Proposed to update to File-scoped namespaces. It was requested to perform the changes in a few PRs to make them smaller and easier to review. This is the one only meant to update .NET version.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • [] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
@gmottajr gmottajr requested a review from siriak as a code owner December 31, 2023 02:46
@codecov
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 215 lines in your changes are missing coverage. Please review.

Comparison is base (3d92c39) 94.50% compared to head (2786dc5) 94.50%.

Files Patch % Lines
Algorithms/Search/AStar/AStar.cs 0.00% 65 Missing ⚠️
Algorithms/Search/AStar/PriorityQueue.cs 0.00% 56 Missing ⚠️
Algorithms/Search/AStar/VecN.cs 0.00% 38 Missing ⚠️
Algorithms/Search/AStar/Node.cs 0.00% 26 Missing ⚠️
Algorithms/Other/RGBHSVConversion.cs 89.47% 0 Missing and 8 partials ⚠️
Algorithms/Search/FibonacciSearcher.cs 88.57% 2 Missing and 2 partials ⚠️
Algorithms/Search/RecursiveBinarySearcher.cs 77.77% 0 Missing and 4 partials ⚠️
...thms/Problems/NQueens/BacktrackingNQueensSolver.cs 95.23% 0 Missing and 2 partials ⚠️
Algorithms/Problems/StableMarriage/GaleShapley.cs 92.00% 1 Missing and 1 partial ⚠️
Algorithms/Search/BinarySearcher.cs 84.61% 0 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files
@@ Coverage Diff @@ ## master #431 +/- ## ======================================= Coverage 94.50% 94.50% ======================================= Files 234 234 Lines 9843 9843 Branches 1455 1455 ======================================= Hits 9302 9302 Misses 381 381 Partials 160 160 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit fdfc765 into TheAlgorithms:master Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants