Migrate Project to .NET 8: Update Target Framework. #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Migrating to .NET 8 changes the way the project is built or introduces new requirements (like a specific version of the .NET SDK), it's important to update the README to reflect these changes. New Features or Limitations: The migration introduces new features (like utilizing new C# language features) or has specific limitations (such as compatibility issues with certain environments), these should be documented. Testing and Usage Instructions: The migration impacts how tests are run or how the project should be used, updating the README is necessary to guide other contributors or users.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #426 +/- ## ========================================== - Coverage 94.50% 94.46% -0.05% ========================================== Files 234 234 Lines 9843 9843 Branches 1451 1455 +4 ========================================== - Hits 9302 9298 -4 - Misses 381 384 +3 - Partials 160 161 +1 ☔ View full report in Codecov by Sentry. |
Member
| Please also update .NET version in ci.yml |
Contributor Author
| Sure, done! |
Member
| Please fix Codacy issues. Codecov is fine, I can merge with that. |
Contributor Author
| I'm not getting any issue. Perhaps I'm going to ne you showing me what you see. |
Member
| They are here. You can click on Details to see details. |
…ggestions from Codacy Static Code Analysis, particularly about the unordered list marker style in the README.md, suggesting a change to the * marker style.
Contributor Author
| Gotcha! |
Contributor Author
| You are welcome! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Migration to .NET 8: .csproj files are being updated.
Please let me know whether or not it would be necessary to create new unit tests for this change.
Motivation and Context
Github issue #425: Proposed to migrate to .NET 8 to use the latest features of .NET ecosystem. It was requested to perform the changes in a few PRs to make them smaller and easier to review. This is the one only meant to update .NET version.