[encoder] Allow setting the initial value manually #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sometimes it's desirable to set the initial value to a predefined value (say, a encoder that controls both "volume" and "frequency", by switching between these functions, it's helpful if we can set the initial value to the current internal value. I've been doing this by setting the min_val to -100, and then applying the offset to my current value, but I've figured this is more elegant. I've tried to keep it compatible with how it was previously, but please correct me if this is not right.
SpotlightKid changed the title 
Owner
| Good idea, thanks! I'll change the position of the |
Contributor Author
| Thank you for the quick merge. I left it as the last so it remains compatible with previous versions, but I agree it would make sense to keep it together with min and max values. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sometimes it's desirable to set the initial value to a predefined value (say, a encoder that controls both "volume" and "frequency", by switching between these functions, it's helpful if we can set the initial value to the current internal value.
I've been doing this by setting the min_val to -100, and then applying the offset to my current value, but I've figured this is more elegant.
I've tried to keep it compatible with how it was previously, but please correct me if this is not right.