fix: update the way SortableJS is imported into the library #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is due to a breaking change in SortableJS: SortableJS/Sortable#1728, which causes angular-legacy-sortable to imports SortableJS incorrectly after versions 1.10.0, which leads to it not finding Sortablejs.create.
Big bump since this fixes a breaking change
| Mistyped this in this repo instead of my forked repository, lol. Please ignore >< |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is due to a breaking change SortableJS/Sortable#1728, which causes https://github.com/SortableJS/angular-legacy-sortablejs/ to imports SortableJS incorrectly after versions 1.10.0, which leads to it not finding Sortablejs.create.
See:
This fix is obtained from #53, but since the repo seems to now be unmaintained, I've decided to fork that repo to fix that issue.