Master3x.webpack #285
Merged
Master3x.webpack #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…webpack # Conflicts: # quickblox.min.js
dimaspirit reviewed Nov 15, 2017
package.json Outdated
| "scripts": { | ||
| "start": "cross-env NODE_ENV=development ./node_modules/.bin/webpack --config webpack.config.js --watch", | ||
| "build": "webpack --config webpack.config.js", | ||
| "start": "cross-env NODE_ENV=development ./node_modules/.bin/webpack --config webpack.config.js", |
Contributor
There was a problem hiding this comment.
Could we make simple - start and build command?
start is prepare env and tools for developing (watching, server).
build is make build version of sdk.
dimaspirit reviewed Nov 15, 2017
webpack.config.js Outdated
| @@ -1,8 +1,11 @@ | |||
| const path = require('path'); | |||
| const webpack = require('webpack'); | |||
| const MinifyPlugin = require("babel-minify-webpack-plugin"); | |||
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Build tools were updated