WIP - Bug Fixing #180
Merged
WIP - Bug Fixing #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
IegorKozakov commented Nov 28, 2016
IegorKozakov commented - Logout with expired session (WebRTC sample)
dimaspirit reviewed Dec 19, 2016
samples/webrtc/js/app.js Outdated
| var peerState = app.currentSession.connectionStateForUser(userID), | ||
| userInfo = _.findWhere(app.users, {'id': +userID}); | ||
| | ||
| console.log('opponents.forEach peerState', peerState); |
dimaspirit reviewed Dec 19, 2016
samples/webrtc/js/app.js Outdated
| videoElems += compiled({ | ||
| 'userID': userID, | ||
| 'name': userInfo.full_name, | ||
| 'name': userInfo ? userInfo.full_name : 'Unknown user', |
Contributor
There was a problem hiding this comment.
Instead of 'Unknown user' use userID, please
dimaspirit reviewed Dec 19, 2016
samples/webrtc/js/app.js Outdated
| 'name': app.caller.full_name, | ||
| } | ||
| }); | ||
| // app.helpers.notifyIfUserLeaveCall(session, session.opponentsIDs[0], 'closed'); |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.