[MRG] Fix bugs for partial OT #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #215 +/- ## ========================================== - Coverage 92.28% 88.34% -3.94% ========================================== Files 15 19 +4 Lines 3006 3157 +151 ========================================== + Hits 2774 2789 +15 - Misses 232 368 +136 |
Collaborator
| why codecov ? why? those files are supposed to be excluded! |
agramfort reviewed Oct 20, 2020
README.md Outdated
| <<<<<<< HEAD | ||
| | ||
| [29] Chapel, L., Alaya, M., Gasso, G. (2020). [Partial Optimal Transport with Applications on Positive-Unlabeled Learning](https://arxiv.org/abs/2002.08276), Advances in Neural Information Processing Systems (NeurIPS), 2020. | ||
| ======= |
README.md Outdated
| [29] Chapel, L., Alaya, M., Gasso, G. (2019). [Partial Gromov-Wasserstein with Applications on Positive-Unlabeled Learning](https://arxiv.org/abs/2002.08276), arXiv preprint arXiv:2002.08276. | ||
| | ||
| [30] Flamary R., Courty N., Tuia D., Rakotomamonjy A. (2014). [Optimal transport with Laplacian regularization: Applications to domain adaptation and shape matching](https://remi.flamary.com/biblio/flamary2014optlaplace.pdf), NIPS Workshop on Optimal Transport and Machine Learning OTML, 2014. | ||
| >>>>>>> 55164e9272c9899ca413fca411d410ec28b736b0 |
Codecov Report
@@ Coverage Diff @@ ## master #215 +/- ## ========================================== - Coverage 92.28% 88.34% -3.94% ========================================== Files 15 19 +4 Lines 3006 3157 +151 ========================================== + Hits 2774 2789 +15 - Misses 232 368 +136 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
Corrects some bugs on partial-OT and references related to partial-OT
How has this been tested (if it applies)
Checklist
This PR fixes:
the use of the dummy points in function partial_wasserstein
the computation of gamma in function partial_gromov_wasserstein
update the reference paper