Skip to content

Restrict Armijo linesearch function step to be at most 1 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Restrict Armijo linesearch function step to be at most 1 #189

merged 1 commit into from
May 25, 2020

Conversation

@panispani
Copy link
Contributor

@panispani panispani commented May 25, 2020 •
edited
Loading

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and context / Related issue

Issue: line_search_armijo returns alpha > 1

How has this been tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document.
  • All tests passed, and additional code has been covered with new tests.
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## master #189 +/- ## ======================================= Coverage 92.27% 92.27% ======================================= Files 15 15 Lines 3004 3004 ======================================= Hits 2772 2772 Misses 232 232
@ncourty ncourty merged commit 5af6452 into PythonOT:master May 25, 2020
@rflamary rflamary mentioned this pull request May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@panispani @codecov-commenter @ncourty