Skip to content

[MRG] Fix requirements #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2020
Merged

[MRG] Fix requirements #174

merged 2 commits into from
May 14, 2020

Conversation

@djsutherland
Copy link
Contributor

@djsutherland djsutherland commented May 13, 2020

As mentioned in conda-forge/pot-feedstock#9 (comment) – the setup_requires and install_requires seem to be slightly wrong as they are now (and there's no such key as requires as far as I can tell).
@djsutherland
Copy link
Contributor Author

djsutherland commented May 13, 2020

It's failing from flake8 on a file I didn't touch...I'll send a different PR I guess.
@djsutherland
Copy link
Contributor Author

djsutherland commented May 13, 2020

(Rebased onto #176 to avoid the flake8 error.)
@rflamary rflamary changed the title fix requirements [MRG] Fix requirements May 14, 2020
@rflamary
Copy link
Collaborator

rflamary commented May 14, 2020

I agree this is a much better requirement definition. we were clearly over eager before.
@rflamary rflamary merged commit 7bc3104 into PythonOT:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@djsutherland @rflamary @agramfort