Docker-related fixes for v0.5.1 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Onur Ülgen <onur.ulgen@kcl.ac.uk>
Signed-off-by: Onur Ülgen <onur.ulgen@kcl.ac.uk>
Collaborator
| Thanks! Good idea to show people how to work around the issue with deprecated nvidia-docker2. I've advised users to patch the SDK v0.5 once installed and meant to add a discussion topic instead of fixing the legacy code while without plan to release a v0.5 patch release. Please see if you can create a discussion with the same info, in the meantime I'll review the code. |
Docker images based on Ubuntu 22.04 and later lacks libssl1 on which monai-executor depends. Signed-off-by: Onur Ülgen <onur.ulgen@kcl.ac.uk>
|
MMelQin changed the title 
MMelQin approved these changes Feb 4, 2025
Collaborator
MMelQin left a comment
MMelQin left a comment There was a problem hiding this comment.
Removed the [WIP] before merging. Look good and the users are expected to have installed NVIDIA Container Toolkit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request contains some fixes for docker-related commands on v0.5.1. I know there are newer versions, but this can help people who are using older versions.