Skip to content

Update to release v2.0 that is dependent on HSDK v2 #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2024
Merged

Update to release v2.0 that is dependent on HSDK v2 #485

merged 5 commits into from
Apr 24, 2024

Conversation

@MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Apr 22, 2024 •
edited
Loading

Changes needed to prepare for v2.0 release (on the newly release Holoscan SDK v2.0):

  • Updated the SDK to use Holoscan SDK V2.x, holoscan~=2.0
  • Fixed a field issue where DICOMDir was erroneously exported from the PACS and ingested by the MIG, and not filtered out by the MD App SDK. The fix is to add a exclusion/ignore list of unwanted SOP Classes by the UID, e.g. DICOMDir SOP Class
MMelQin added 4 commits April 22, 2024 16:12
@MMelQin
Update to use HSDK v2
b624b34 
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@MMelQin
Supress the new Flake8 complaints
b869749 
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@MMelQin
Avoid loading DICOMDir and tested all notebooks
6f48bf3 
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@MMelQin
fix flake8 complaint
ec3094c 
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@MMelQin MMelQin changed the title WIP: Update to use HSDK v2 Update to release v2.0 that is dependent on HSDK v2 Apr 24, 2024
@MMelQin
logging the UID, if present, of the ignored instance
991c7e7 
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud
@MMelQin MMelQin merged commit ca30b03 into main Apr 24, 2024
@MMelQin MMelQin linked an issue Apr 24, 2024 that may be closed by this pull request
[BUG] DICOM Loader should ignore DICOMDIR insance #486
Closed
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jun 26, 2025
@MMelQin @SimoneBendazzoli93
Update to release v2.0 that is dependent on HSDK v2 (Project-MONAI#485)
f8e0aef 
* Update to use HSDK v2 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Supress the new Flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Avoid loading DICOMDir and tested all notebooks Signed-off-by: M Q <mingmelvinq@nvidia.com> * fix flake8 complaint Signed-off-by: M Q <mingmelvinq@nvidia.com> * logging the UID, if present, of the ignored instance Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
@MMelQin @SimoneBendazzoli93
Update to release v2.0 that is dependent on HSDK v2 (Project-MONAI#485)
1c9772a 
* Update to use HSDK v2 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Supress the new Flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Avoid loading DICOMDir and tested all notebooks Signed-off-by: M Q <mingmelvinq@nvidia.com> * fix flake8 complaint Signed-off-by: M Q <mingmelvinq@nvidia.com> * logging the UID, if present, of the ignored instance Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
@MMelQin @SimoneBendazzoli93
Update to release v2.0 that is dependent on HSDK v2 (Project-MONAI#485)
af3bfa4 
* Update to use HSDK v2 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Supress the new Flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Avoid loading DICOMDir and tested all notebooks Signed-off-by: M Q <mingmelvinq@nvidia.com> * fix flake8 complaint Signed-off-by: M Q <mingmelvinq@nvidia.com> * logging the UID, if present, of the ignored instance Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com>
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
@MMelQin @SimoneBendazzoli93
Update to release v2.0 that is dependent on HSDK v2 (Project-MONAI#485)
4e1b32b 
* Update to use HSDK v2 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Supress the new Flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Avoid loading DICOMDir and tested all notebooks Signed-off-by: M Q <mingmelvinq@nvidia.com> * fix flake8 complaint Signed-off-by: M Q <mingmelvinq@nvidia.com> * logging the UID, if present, of the ignored instance Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93 pushed a commit to SimoneBendazzoli93/monai-deploy-app-sdk that referenced this pull request Jul 17, 2025
@MMelQin @SimoneBendazzoli93
Update to release v2.0 that is dependent on HSDK v2 (Project-MONAI#485)
7bebf05 
* Update to use HSDK v2 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Supress the new Flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Avoid loading DICOMDir and tested all notebooks Signed-off-by: M Q <mingmelvinq@nvidia.com> * fix flake8 complaint Signed-off-by: M Q <mingmelvinq@nvidia.com> * logging the UID, if present, of the ignored instance Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
@MMelQin MMelQin deleted the mqin/updates_v2 branch November 5, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@MMelQin @mocsharp