Skip to content

issue #251 #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2016
Merged

issue #251 #253

merged 1 commit into from
Aug 25, 2016

Conversation

@fieliapm
Copy link
Contributor

@fieliapm fieliapm commented Aug 25, 2016 •
edited
Loading

In master branch, flask_mongoengine/connection.py, line 265:

if conn_setting.pop('replicaset', None): resolved['replicaSet'] = conn_setting.pop('replicaset', None)

what is f***ing going on lol

Because dict.pop() will return and also remove specific key value
pair from dict, so we cannot do dict.pop() twice.
Actually this code should be:

replica_set = conn_setting.pop('replicaset', None) if replica_set: resolved['replicaSet'] = replica_set
@fieliapm
issue MongoEngine#251
c8d988f 
In master branch, flask_mongoengine/connection.py, line 265: if conn_setting.pop('replicaset', None): resolved['replicaSet'] = conn_setting.pop('replicaset', None) what is f***ing going on lol Because dict.pop() will return and also remove specific key value pair from dict, so we cannot do dict.pop() twice. Actually this code should be: replica_set = conn_setting.pop('replicaset', None) if replica_set: resolved['replicaSet'] = replica_set
@losintikfos losintikfos merged commit de0d277 into MongoEngine:master Aug 25, 2016
@lafrech lafrech mentioned this pull request Aug 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@fieliapm @losintikfos