Skip to content

Conversation

@brandonstubbs
Copy link

@brandonstubbs brandonstubbs commented Mar 20, 2024

I missed the step of updating the connector code to change the schema parameter and it took a while to figure out why all my unit tests were coming back as null except for the Check that we have three entries in our nav table test. It might be better to explicitly show this step. LMKWYT

@prmerger-automator prmerger-automator bot added the do-not-merge Don't merge this yet label Mar 20, 2024
@prmerger-automator
Copy link
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 8eccc7d:

✅ Validation status: passed

File Status Preview URL Details
powerquery-docs/samples/trippin/7-advancedschema/readme.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Mar 21, 2024

@DougKlopfenstein

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@JasonWHowell JasonWHowell added the needs-engineering-review Discussing with Microsoft's engineering team. label May 28, 2024
@ktoliver
Copy link

ktoliver commented Nov 3, 2025

@JasonWHowell @ptyx507x - Is this proposed update still slated for engineering review?

@JasonWHowell
Copy link
Collaborator

@ktoliver I'm not on this team any longer. @DougKlopfenstein is the writer on Kate's team.

@ktoliver
Copy link

ktoliver commented Nov 3, 2025

@ktoliver I'm not on this team any longer. @DougKlopfenstein is the writer on Kate's team.

OK, thanks @JasonWHowell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment