Fix handling of OIDs >= 2**31 #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1st1 approved these changes May 31, 2018
asyncpg/connection.py Outdated
| | ||
| oid = typeinfo['oid'] | ||
| if typeinfo['kind'] != b'b' or typeinfo['elemtype']: | ||
| if typeinfo['kind'] not in (b'b', b'd') or typeinfo['elemtype']: |
Member
There was a problem hiding this comment.
Please add a comment what b'b' and b'd' mean
asyncpg/protocol/codecs/base.pyx Outdated
| except OverflowError: | ||
| overflow = True | ||
| | ||
| if overflow or (oid < 0 or oid > 4294967295L): |
asyncpg/protocol/codecs/misc.pyx Outdated
| | ||
| for oid_type in oid_types: | ||
| register_core_codec(oid_type, | ||
| <encode_func>&int4_encode, |
Member
There was a problem hiding this comment.
Maybe add uint4_encode with validation?
Previously this was disallowed for no particular reason.
The current `TestCase.start_cluster()` helper is not flexible enough as it does not allow making customizations to the cluster before it is started. The new `TestCase.new_cluster()` and `TestCase.start_cluster()` are now used instead. Cluster cleanup is now automatic.
1st1 approved these changes May 31, 2018
Currently asyncpg (incorrectly) assumes OIDs to be signed 32-bit integers, whereas in reality they are unsigned. As a result, things would crash once the OID sequence reaches 2**31. Fix this by decoding OID values as unsigned longs. Fixes: #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently asyncpg (incorrectly) assumes OIDs to be signed 32-bit
integers, whereas in reality they are unsigned. As a result, things
would crash once the OID sequence reaches 2**31.
Fix this by decoding OID values as unsigned longs.
Fixes: #279