Prohibit non-iterable containers to be passed as array input #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1st1 reviewed Mar 5, 2018
tests/test_codecs.py Outdated
| return False | ||
| | ||
| with self.assertRaisesRegex(TypeError, | ||
| 'non-trivial iterable expected'): |
Member
There was a problem hiding this comment.
Maybe "non-trivial iterable" -> "sized iterable container"?
1st1 approved these changes Mar 5, 2018
Make the array input type check for correct ABCs instead of producing a cryptic error when a non-iterable container is passed.
elprans force-pushed the only-allow-sized-iterables-for-array-input branch from b91d222 to 5886325 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make the array input type check for correct ABCs instead of producing a
cryptic error when a non-iterable container is passed.