Ignore unpressed events during velocity calculation on iOS #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
igordmn force-pushed the igor.demin/revert-hitpathtracker branch from 56bebb9 to 53cfaab Compare Base automatically changed from igor.demin/revert-hitpathtracker to jb-main September 27, 2023 18:03
elijah-semyonov force-pushed the es/fix-velocity-calculation branch from c10d9e0 to c2c6176 Compare This reverts commit c2c6176.
MatkovIvan reviewed Oct 12, 2023
compose/ui/ui/src/jvmMain/kotlin/androidx/compose/ui/input/pointer/util/VelocityTracker.jvm.kt Outdated Show resolved Hide resolved
MatkovIvan reviewed Oct 12, 2023
| /** | ||
| * Some platforms (e.g. iOS) velocity calculation is incorrect when end position is used in velocity calculation. | ||
| */ | ||
| internal expect val onlyPressedEventsForVelocityTracker: Boolean |
There was a problem hiding this comment.
Suggestion: hide such details in ios-actual and use something like:
internal expect fun VelocityTracker.shouldUse(event: PointerInputChange) igordmn pushed a commit that referenced this pull request Nov 15, 2023
igordmn pushed a commit that referenced this pull request Nov 16, 2023
…during velocity calculation on iOS (#848)
mazunin-v-jb pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Ignore unpressed events during velocity calculation on iOS.
Testing
Test: check that no unintended fling happens during drag-and-stop sequences