Integrate ACL groovy based engine, part 1 #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Test Coverage Report
|
crazyrokr requested changes Dec 14, 2025
| where: | ||
| mqttUser | condition | expectedResult | ||
| new TestMqttUser(null, "username2", null) | new AnyOfCondition(userNameEquals("username2")) | true | ||
| new TestMqttUser(null, "username2", null) | new AnyOfCondition(userNameEquals("username2")) | true |
Collaborator
There was a problem hiding this comment.
Please apply formatting to all test cases
| PUBLISH | new AllowSubscribeRule(clientIdEquals("clientId"), TopicCondition.MATCH_ANY) | false | ||
| SUBSCRIBE | new AllowSubscribeRule(clientIdEquals("clientId"), TopicCondition.MATCH_ANY) | true | ||
| PUBLISH | new DenyPublishRule(clientIdEquals("clientId"), TopicCondition.MATCH_ANY) | true | ||
| PUBLISH | new DenyPublishRule(clientIdEquals("clientId"), TopicCondition.MATCH_ANY) | true |
crazyrokr approved these changes Dec 14, 2025
JavaSaBr deleted the feature/142-integrate-acl-groovy-based-engine-part-1 branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#142
Reorganize ACL engine related classes: