Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Conversation

@Tomcli
Copy link
Contributor

@Tomcli Tomcli commented Nov 18, 2017

Update metrics job with the newest requirement

  • add java language field for the metrics job

Cc @animeshsingh

Copy link

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq - shouldn't language go in config var itself like other? And maybe same for microprofile one

@Tomcli
Copy link
Contributor Author

Tomcli commented Nov 19, 2017

It’s easier for the job to parse/format the parameter this way. Also, since the job will be generated with python script, there won’t be extra work for the developers to create this job.

loafyloaf
loafyloaf previously approved these changes Nov 21, 2017
@loafyloaf loafyloaf merged commit 1944712 into master Dec 1, 2017
@loafyloaf loafyloaf deleted the Metrics branch December 5, 2017 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants