This repository was archived by the owner on Jul 18, 2024. It is now read-only.
Fix scripts to check for PR #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AnthonyAmanse force-pushed the fix-scripts branch from 4d9027d to c5f95fb Compare AnthonyAmanse force-pushed the fix-scripts branch from c5f95fb to 7d284dc Compare 3 tasks
mlangbehn suggested changes Oct 23, 2017
scripts/bx_auth.sh Outdated
| | ||
| if [[ -z "$BLUEMIX_AUTH" ]]; then | ||
| if [[ "$TRAVIS_PULL_REQUEST" != "false" ]]; then | ||
| echo -e "\033[0;33mFork detected; not authenticating to Bluemix.\033[0m" |
There was a problem hiding this comment.
Keep in mind that this is not actually detecting a fork, it is detecting a pull request. Let's update the message to reflect this.
tests/test-kubeadm-dind-cluster.sh Outdated
| main(){ | ||
| | ||
| if [[ -z "$BLUEMIX_AUTH" ]] | ||
| if [[ "$TRAVIS_PULL_REQUEST" != "false" ]] |
There was a problem hiding this comment.
Why would we want to only run this test if a pull request is detected? The point of this test is so that we can have a kubernetes deployment in CI.
Changed scripts to enhance Travis CI. Various scripts change to check for TRAVIS_PULL_REQUEST instead of BLUEMIX_AUTH. Change $NODE_PORT to 30080 in test-kubernetes.sh. kubeadm test is now ran regardless if it is a PR or not.
AnthonyAmanse force-pushed the fix-scripts branch from 7d284dc to e8b553f Compare 
loafyloaf reviewed Oct 24, 2017
There was a problem hiding this comment.
I'm late to the party, as usual. But looks good - thanks @AnthonyAmanse
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replaced
BLUEMIX_AUTHtoTRAVIS_PULL_REQUESTQuick change of
$NODE_PORTvariable to30080