This repository was archived by the owner on Jul 18, 2024. It is now read-only.
Fix tests with bx auth #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mlangbehn reviewed Oct 12, 2017
scripts/bx_auth.sh Outdated
| BLUEMIX_SPACE="dev" | ||
| | ||
| if [[ -z "$BLUEMIX_AUTH" ]]; then | ||
| if [[ -z "$BLUEMIX_API_KEY" ]]; then |
There was a problem hiding this comment.
Quick point, this isn't actually testing if we are in a fork, it is only testing if BLUEMIX_API_KEY is set. Would it be better to check if TRAVIS_PULL_REQUEST is set (see here for example)?
scripts/install_bx.sh Outdated
| #!/bin/bash -e | ||
| | ||
| if [[ -z "$BLUEMIX_AUTH" ]]; then | ||
| if [[ -z "$BLUEMIX_API_KEY" ]]; then |
There was a problem hiding this comment.
See comment from scripts/bx_auth.sh.
tests/test-kubeadm-dind-cluster.sh Outdated
| main(){ | ||
| | ||
| if [[ -z "$BLUEMIX_AUTH" ]] | ||
| if [[ -z "$BLUEMIX_API_KEY" ]] |
There was a problem hiding this comment.
See comment from scripts/bx_auth.sh.
tests/test-kubernetes.sh Outdated
| | ||
| main(){ | ||
| if [[ -z "$BLUEMIX_AUTH" ]]; then | ||
| if [[ -z "$BLUEMIX_API_KEY" ]]; then |
There was a problem hiding this comment.
See comment from scripts/bx_auth.sh.
AnthonyAmanse force-pushed the bx-auth branch from 7730ae6 to a5b4d9e Compare AnthonyAmanse force-pushed the bx-auth branch from a5b4d9e to 6f0c00d Compare AnthonyAmanse force-pushed the bx-auth branch from bf96403 to b49d533 Compare 
| @mlangbehn |
AnthonyAmanse force-pushed the bx-auth branch from 73c00e1 to b49d533 Compare 
AnthonyAmanse force-pushed the bx-auth branch from cef9296 to b6c1bd5 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replaced
BLUEMIX_AUTHtoTRAVIS_PULL_REQUESTQuick change of
$NODE_PORTvariable to30080