Allow leaving corrupted indexes as readable after header repair #3801
Conversation
In the case of a broader corruption, where records have been corrupted along with the store header, it may be beneficial to look at the indexes involved while looking at the store. This may be useful if you want to resurrect some information from the indexes if any exists.
| * @return a boolean indicating whether a repair needed to be done ({@code true}) or not ({@code false}) and | ||
| * the opened store. | ||
| */ | ||
| @API(API.Status.INTERNAL) |
There was a problem hiding this comment.
Maybe we should consider changing that to EXPERIMENTAL?
| * determine that the index can be marked readable for free, but this is not supported. | ||
| * If {@code leavePotentiallyCorruptIndexesReadable} is {@code true} they will not be disabled. | ||
| * This can be useful if you want to use the potentially corrupt indexes to discern information | ||
| * about the corrupted records. |
There was a problem hiding this comment.
Add some verbiage about the inability to commit?
| return simpleMetaData(metadata -> metadata.setSplitLongRecords(supportSplitRecords)); | ||
| } | ||
| | ||
| private void withStore(final FormatVersion formatVersion, |
There was a problem hiding this comment.
I know this is replacing existing code but it does look fragile in the sense that it creates the store and assumes that the runnable is using the global field for its action - it can be made a little more resilient if the runnable was a consumer of a store instead
There was a problem hiding this comment.
Yeah, but that only works if the recordStore field is removed entirely. Which I did, and I think it does make the code more resilient. I had to add some logic around metadata because this now has a different base class, but not much.
…tBase As noted in the PR `withStore` was potentially brittle because of the `recordStore` field. I could have changed that to a consumer but still set the field, but that felt just as bad, so I changed it to extend FDBRecordStoreConcurrentTestBase.
2 participants
In the case of a broader corruption, where records have been corrupted along with the store header, it may be beneficial to look at the indexes involved while looking at the store. This may be useful if you want to resurrect some information from the indexes if any exists.