Create validation runner #3360
Draft
Create validation runner #3360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…record-validation-phase-2 # Conflicts: # fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/cursors/throttled/ThrottledRetryingIterator.java # fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/cursors/throttled/ThrottledIteratorTest.java
- Added comments to tests - extracted increaLimit and decreaseLimit methods, added tests - Fixed issue with increase limit being stuck under 4
- Increase increment to 4 - make class EXPERIMENTAL
- added executor to whileTrue call - always clearWeakReadSemantics=true - improve close cursors - catch `RunnerClosed` exception, don't retry
- Remove row limit controls - Fix tests - add deleteLimit to tests - fix delete limit off-by-one bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR introduces the
RecordValidationRunnerthat combines the various pieces of the record validation framework.This represents the externally visible API that we expect users to leverage in order to repair corrupt records in stores.
The repair runner has 2 main entry points:
runValidationStatsthat returns an aggregation of the errors foundrunValidationAndRepairthat returns (and optionally repairs) individual record stateNote that in this PR,
repairoption is not yet supported.Resolves #3359