feat: update graphql-java version #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
samuelAndalon commented Apr 16, 2023
| * @param propertyGetter Kotlin's property getter that will be invoked to resolve a field | ||
| */ | ||
| class PropertyDataFetcher(private val propertyGetter: KProperty.Getter<*>) : TrivialDataFetcher<Any?> { | ||
| class PropertyDataFetcher(private val propertyGetter: KProperty.Getter<*>) : LightDataFetcher<Any?> { |
There was a problem hiding this comment.
PropertyDataFetcher will now implement the LightDataFetcher, which will make the execution engine to create the dataFetchingEnviroment on demand, most (if not all), PropertyDataFetchers dont require this field, so this will represent a memory improvement
dariuszkuc reviewed Apr 17, 2023
...ediagroup/graphql/examples/server/spring/instrumentation/TrackTimesInvokedInstrumentation.kt Outdated Show resolved Hide resolved
samuelAndalon added the type: dependency changes dariuszkuc approved these changes Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📝 Description
update
graphql-javafrom 19.2 to 20.2https://github.com/graphql-java/graphql-java/releases/tag/v20.0
https://github.com/graphql-java/graphql-java/releases/tag/v20.1
https://github.com/graphql-java/graphql-java/releases/tag/v20.2
graphql-java 20.0 introduces Lightweight Data Fetchers under the LightDataFetcher interface, which will avoid creating a
DataFetchingEnvironmentinstance each time the execution engine attempt to resolve a property using thePropertyDataFetcher.updates federation-jvm to 3.0.0