Skip to content

Conversation

@cipheraxat
Copy link
Member

@cipheraxat cipheraxat commented Oct 9, 2020

Pull Request.

Kindly adhere to the template!

Generate a Pull Request if the code fixes an issue, or if you feel that the change is important and the world would stop spinning without it.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #(issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).
  • This change requires a documentation update.
  • The code follows the code style of this project.
  • Documentation has been updated accordingly.
  • Tests have been added to cover the changes.
  • All new and existing tests passed.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment