Skip to content

Conversation

seuros
Copy link
Member

@seuros seuros commented May 14, 2014

No description provided.

@mceachen
Copy link
Collaborator

Thanks for the assist!

@seuros
Copy link
Member Author

seuros commented May 14, 2014

do you plan to use rspec 3 ?

@seuros
Copy link
Member Author

seuros commented May 15, 2014

Travis is doing weird stuffs in some tests.

@seuros
Copy link
Member Author

seuros commented May 15, 2014

I think I'm done with this PR.

@seuros
Copy link
Member Author

seuros commented May 15, 2014

@mceachen can you see why travis fails sometime in postgresql ?

@seuros
Copy link
Member Author

seuros commented May 16, 2014

@mceachen , are you interested in adding a feature like #80 ?

@mceachen
Copy link
Collaborator

Thanks for your work here—I'll check it out this weekend!

@seuros
Copy link
Member Author

seuros commented May 17, 2014

Ok, thank you. Can you double check if i missed any key in c8e9114 .

Cleaner test script Removed foreigner from gemspec to remove the warning duplicate gem message
@seuros
Copy link
Member Author

seuros commented May 17, 2014

Why are you creating databases with travis jobs prefixed ? Each job is isolated as far as i know.

@mceachen
Copy link
Collaborator

The advisory lock is against a given schema, so if the test runs share a
host machine, they affect each other. (!!)
On May 17, 2014 10:23 AM, "Abdelkader Boudih" notifications@github.com
wrote:

Why are you creating databases with travis jobs prefixed ? Each job is
isolated as far as i know.


Reply to this email directly or view it on GitHubhttps://github.com//pull/99#issuecomment-43415858
.

@mceachen
Copy link
Collaborator

Hey, thanks for switching to appraisal! That's a sweet gem!

@mceachen mceachen merged commit 0f220e1 into ClosureTree:master May 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants