Fix regex and both for import and export route-targets NXOS #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
Taarini requested changes Jul 18, 2024
Contributor
Taarini left a comment
Taarini left a comment There was a problem hiding this comment.
Thanks for your contribution. Sorry for not reviewing it sooner
Could you also add UT
| # route-target both auto mvpn | ||
| # route-target both auto evpn | ||
| p5 = re.compile(r'^\s*route-target +(?P<rt_type>\w+) +(?P<rt>\w+)( +(?P<rt_evpn_mvpn>\w+))?$') | ||
| p5 = re.compile(r'^\s*route-target +(?P<rt_type>\w+) +(?P<rt>\w+:\w+)( +(?P<rt_evpn_mvpn>\w+))?$') |
Contributor
There was a problem hiding this comment.
Please add comment for the regex change
Author
There was a problem hiding this comment.
Sorry, but I'm not sure what comment to add, since it should have been like this from the start.
Also UT = Usertest? Just some examples, from before and after the change?
I'm till very interested in getting this fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I have changed the regex pattern for matching route-target to include ':'.
A ':' is required when configuring a import/export route-target.
I have also fixed, so a route-target can be 'both' imported and exported at the same time.
Motivation and Context
This fixes the "show running-config vrf {vrf} | sec '^vrf'" command on NXOS.
Before route-targets would not be parsed, and not appear in parsed output.
Impact (If any)
No negative impact, as this did not work previously.
Screenshots:
Checklist: