Skip to content

Conversation

@yeskunall
Copy link

@yeskunall yeskunall commented Dec 10, 2025

Bitnami deprecated bitnami/minio earlier this year in August. Simply switching to use minio/minio didn’t work, however. LMK if there’s anything I need to do to get this merged.


💖

Summary by CodeRabbit

  • Bug Fixes

    • Fixed typo in local S3 storage comment.
  • Chores

    • Switched MinIO image and updated container configuration.
    • Enabled MinIO console interface while preserving existing port exposure.
    • Simplified MinIO data volume path and removed redundant environment variables.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

Switches the Docker Compose MinIO service from Bitnami to the official MinIO image, adds a command to run the server on /data with API and console addresses, adjusts the data volume mount path, fixes a comment typo, and removes two MinIO port-related environment variables.

Changes

Cohort / File(s) Summary
MinIO image & compose configuration
docker-compose.template.yml
Corrected comment typo from "Strorage" to "Storage"; replaced image bitnami/minio:latestminio/minio:latest; added command: server /data --address :3902 --console-address :3903; exposes ports 3902 and 3903 (both kept); changed container data mount from /bitnami/minio/data/data and updated the volume mapping; removed environment variables MINIO_API_PORT_NUMBER and MINIO_CONSOLE_PORT_NUMBER; retained MINIO_ROOT_USER and MINIO_ROOT_PASSWORD.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single declarative file changed with configuration updates.
  • Review focus:
    • Verify command syntax and port bindings.
    • Ensure volume path change aligns with existing data/migration needs.
    • Confirm removal of MINIO_API_PORT_NUMBER / MINIO_CONSOLE_PORT_NUMBER has no downstream references.

Poem

🐰 A little hop from old to new,
The official MinIO greets the dew,
Ports aligned, the data's found,
Typo mended, volumes bound,
I nibble carrots, then dance around 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: switching from bitnami/minio to minio/minio image in docker-compose.template.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3592280 and 832c5e7.

📒 Files selected for processing (1)
  • docker-compose.template.yml (1 hunks)
🔇 Additional comments (3)
docker-compose.template.yml (3)

48-48: ✓ Typo fixed.

Comment corrected from "Strorage" to "Storage."


51-60: ✓ Migration to official minio/minio looks correct.

The switch from bitnami/minio to minio/minio:latest is complete:

  • Image updated to the official MinIO distribution.
  • Bitnami-specific environment variables (MINIO_API_PORT_NUMBER, MINIO_CONSOLE_PORT_NUMBER) have been removed, as flagged in the prior review.
  • Port configuration moved to command-line flags (--address :3902 --console-address :3903), which is the correct approach for the official image.
  • Retained only the essential env vars: MINIO_ROOT_USER and MINIO_ROOT_PASSWORD.

Please confirm that the command syntax server /data --address :3902 --console-address :3903 is valid for minio/minio:latest by testing the container locally or checking the official MinIO documentation for the exact flag syntax and argument order.


62-62: ✓ Volume mount path updated correctly.

The data volume path has been updated from the Bitnami-specific /bitnami/minio/data to the standard /data, which aligns with the command argument on line 60.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fac67c0 and 3592280.

📒 Files selected for processing (1)
  • docker-compose.template.yml (2 hunks)
🔇 Additional comments (2)
docker-compose.template.yml (2)

48-48: Good catch on the typo fix.

The comment correction from "Local S3 Strorage" to "Local S3 Storage" is appreciated.


53-65: Port and volume configuration is correct.

The exposed ports (3902 for API, 3903 for console) and volume mount path (/data instead of /bitnami/minio/data) are appropriate for the official MinIO image. The command arguments properly configure the API and console server addresses.

@richiemcilroy
Copy link
Member

Awesome! Can you check the coderabbit comments and see if they are applicable?

@yeskunall
Copy link
Author

@richiemcilroy they are! I forgot to yeet those env vars. Can you confirm if things look good now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants