Skip to content

Conversation

@krll-kov
Copy link

Fixed following issue: #1388

Pre-launch Checklist

  • [+] I made sure the project builds.
  • [+] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [+] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
  • [+] I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.
@krll-kov
Copy link
Author

@mvanbeusekom can you review it please?

@mvanbeusekom mvanbeusekom self-assigned this Nov 18, 2024
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krll-kov,

First of all thank you very much for this contribution and apologies for the late reply.

I am hoping you are still willing to contribute, I have reviewed the PR and have some feedback that would be great if you can address (especially since I don't have access to an early Windows 10 machine).

@krll-kov
Copy link
Author

krll-kov commented Nov 6, 2025

@mvanbeusekom this actually fixes 2 more problems now from here (with total of 3):

#1394

m_positionChangedRevoker was defined but never actually used in the package, it only caused constant geo-location usage as soon as app is started, without even using any of the features of this package. It caused network lags, crashes and other staff, so fix is really helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants