Skip to content

Conversation

@ferantivero
Copy link
Contributor

@ferantivero ferantivero commented Apr 16, 2025

Purpose

We wanted to provide a freshness update and cleanup over the code checking libs and refactoring the codebase to remove warnings

Does this introduce a breaking change?

[ ] Yes [x] No 

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix [x] Feature [x] Code style update (formatting, local variables) [x] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other... Please describe: 

How to Test

  1. Start Devcontainer
  2. Modify the appsettings.json with a valid ai endpoint address
  3. Send a prompt
  4. The bot should respond with a message
  • Test the code

This PR is intentionally not introducing any unit tests

What to Check

Verify that the following are valid

  • you can now easily spin-up a devcontainer to run the website
  • remove dead code
  • follow principal .NET conventions
  • implement domain naming conventions
  • removed all warnings
  • libs are up to date
  • vanilla js and simplified markup
  • the zip is updated

Other Information

Working with mocked endpoint

Azure Chatbot Demo

Err handling (the website couldn't reach out the ai endpoint)

Azure Chatbot Demo
@ferantivero ferantivero changed the title patch (code-style): [website] libs, formatting, and conventions [WIP] patch (code-style): [website] libs, formatting, and conventions Apr 16, 2025
@ferantivero ferantivero force-pushed the feature/419568_website-general-upd branch from 1495d57 to 47fbe97 Compare April 21, 2025 12:44
@ferantivero ferantivero changed the title [WIP] patch (code-style): [website] libs, formatting, and conventions feat (code-style): [website] libs, formatting, and conventions Apr 21, 2025
@ferantivero ferantivero marked this pull request as ready for review April 21, 2025 13:13
@ferantivero ferantivero force-pushed the feature/419568_website-general-upd branch from 47fbe97 to 40fef56 Compare April 21, 2025 13:34
@ferantivero ferantivero force-pushed the feature/419568_website-general-upd branch from 40fef56 to fc6a738 Compare April 21, 2025 14:57
@ferantivero ferantivero force-pushed the feature/419568_website-general-upd branch from fc6a738 to 871922c Compare April 21, 2025 15:48
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides removing "GPT" here are some other items for you to review/consider. But generally speaking, this looks great.

@ckittel ckittel merged commit f0664d0 into Azure-Samples:main Apr 22, 2025
1 check passed
ferantivero added a commit to ferantivero/openai-end-to-end-baseline that referenced this pull request Apr 25, 2025
highglights: - feat (code-style): [website] libs, formatting, and conventions (basic-Azure-Samples#40) - Azure-Samples/openai-end-to-end-basic#40 - Chatui .NET 8 (basic-Azure-Samples#4) - Azure-Samples/openai-end-to-end-basic#4 - Updates to ChatUI (basic-Azure-Samples#5) - Azure-Samples/openai-end-to-end-basic#5 Co-authored-by: Chad Kittel <chad.kittel@gmail.com> Co-authored-by: Jason Bouska <jasonbouska@microsoft.com>
ferantivero added a commit to ferantivero/openai-end-to-end-baseline that referenced this pull request Apr 25, 2025
highglights: - feat (code-style): [website] libs, formatting, and conventions (basic-Azure-Samples#40) - Azure-Samples/openai-end-to-end-basic#40 - Chatui .NET 8 (basic-Azure-Samples#4) - Azure-Samples/openai-end-to-end-basic#4 - Updates to ChatUI (basic-Azure-Samples#5) - Azure-Samples/openai-end-to-end-basic#5 Co-authored-by: Chad Kittel <chad.kittel@gmail.com> Co-authored-by: Jason Bouska <jasonbouska@microsoft.com>
ferantivero added a commit to ferantivero/azure-openai-chat-baseline-landing-zone that referenced this pull request Apr 25, 2025
highglights: - feat (code-style): [website] libs, formatting, and conventions (basic-Azure-Samples#40) - Azure-Samples/openai-end-to-end-basic#40 - Chatui .NET 8 (basic-Azure-Samples#4) - Azure-Samples/openai-end-to-end-basic#4 - Updates to ChatUI (basic-Azure-Samples#5) - Azure-Samples/openai-end-to-end-basic#5 Co-authored-by: Chad Kittel <chad.kittel@gmail.com> Co-authored-by: Jason Bouska <jasonbouska@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants