- Notifications
You must be signed in to change notification settings - Fork 33
feat (code-style): [website] libs, formatting, and conventions #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ckittel merged 55 commits into Azure-Samples:main from ferantivero:feature/419568_website-general-upd Apr 22, 2025
Merged
feat (code-style): [website] libs, formatting, and conventions #40
ckittel merged 55 commits into Azure-Samples:main from ferantivero:feature/419568_website-general-upd Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
highlights - a modern ecosystem push - better perf/mem-alloc - remove taken dep
highlights: - early return - inline - improve headers logging for response and content
1495d57 to 47fbe97 Compare 47fbe97 to 40fef56 Compare 40fef56 to fc6a738 Compare fc6a738 to 871922c Compare ckittel requested changes Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides removing "GPT" here are some other items for you to review/consider. But generally speaking, this looks great.
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
…urposes Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
ckittel approved these changes Apr 22, 2025
ckittel approved these changes Apr 22, 2025
ferantivero added a commit to ferantivero/openai-end-to-end-baseline that referenced this pull request Apr 25, 2025
highglights: - feat (code-style): [website] libs, formatting, and conventions (basic-Azure-Samples#40) - Azure-Samples/openai-end-to-end-basic#40 - Chatui .NET 8 (basic-Azure-Samples#4) - Azure-Samples/openai-end-to-end-basic#4 - Updates to ChatUI (basic-Azure-Samples#5) - Azure-Samples/openai-end-to-end-basic#5 Co-authored-by: Chad Kittel <chad.kittel@gmail.com> Co-authored-by: Jason Bouska <jasonbouska@microsoft.com>
ferantivero added a commit to ferantivero/openai-end-to-end-baseline that referenced this pull request Apr 25, 2025
highglights: - feat (code-style): [website] libs, formatting, and conventions (basic-Azure-Samples#40) - Azure-Samples/openai-end-to-end-basic#40 - Chatui .NET 8 (basic-Azure-Samples#4) - Azure-Samples/openai-end-to-end-basic#4 - Updates to ChatUI (basic-Azure-Samples#5) - Azure-Samples/openai-end-to-end-basic#5 Co-authored-by: Chad Kittel <chad.kittel@gmail.com> Co-authored-by: Jason Bouska <jasonbouska@microsoft.com>
ferantivero added a commit to ferantivero/azure-openai-chat-baseline-landing-zone that referenced this pull request Apr 25, 2025
highglights: - feat (code-style): [website] libs, formatting, and conventions (basic-Azure-Samples#40) - Azure-Samples/openai-end-to-end-basic#40 - Chatui .NET 8 (basic-Azure-Samples#4) - Azure-Samples/openai-end-to-end-basic#4 - Updates to ChatUI (basic-Azure-Samples#5) - Azure-Samples/openai-end-to-end-basic#5 Co-authored-by: Chad Kittel <chad.kittel@gmail.com> Co-authored-by: Jason Bouska <jasonbouska@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
We wanted to provide a freshness update and cleanup over the code checking libs and refactoring the codebase to remove warnings
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
appsettings.jsonwith a valid ai endpoint addressThis PR is intentionally not introducing any unit tests
What to Check
Verify that the following are valid
zipis updatedOther Information
Working with mocked endpoint
Err handling (the website couldn't reach out the ai endpoint)