This repository was archived by the owner on Sep 7, 2025. It is now read-only.
Refactoring /sorting/bubble_sort.cpp #328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I am creating a pull request for...
What I did is a process of refactoring to the bubble_sort code base. I've just cleaned it up a little and make it much more understandable, simple and communicative to the user. Of course that it can be better but I leave it better than I found it.
An update to the algorithm is using return instead of break, even tough they act like the same here, break is a bad practice and it should be avoided as it acts like a goto and we all know how harmful goto can be to the code. I consider that using it would make other new programming learners to use this keyword maybe even if is not neccesary.
THIS IS NOT VALID