Make sure this.keyboardWill(Show|Hide)Event exists

[pietropizzi]

It can be undefined thus causing app crashes.

Here's a screenshot from the crash report in fabric:

[alvaromb]

So this means that componentDidMount doesn't get fired in some cases?

[pietropizzi]

I am not sure honestly. They are being set to undefined in getInitialState which maybe is called more often than we think (?). I'm not sure if it is a good idea that getInitialState has side effects, it should just return the initial state.

[alvaromb]

The execution order is getInitialState, componentDidMount and then componentWillUnmount. This is why I don't know why is this happening.

[alvaromb]

Ok, we should move the Keyboard.addListener to the componentWillMount lifecycle event.

[alvaromb]

Do you want to change your PR to provide this? If not, I can change it later today.

[pietropizzi]

@alvaromb you think that will fix it?

I am not sure you should be adding subscriptions in this lifecycle method.

I am not sure it would be a fix, but I am pretty sure you don't need the this. keyboardWillShowEvent = undefined in getInitialState. It will be undefined to start with anyway.

Since I don't really understand why it is happening, I think the safeguard makes sense, no?

[alvaromb]

We should introduce your safety check, for sure. About moving the Keyboard.addListener, this is how the Keyboard module is in the React Native documentation:

I just read React docs and honestly I'm not sure which path is correct ¯_(ツ)_/¯

It seems that at some point your component unmounts before calling componentDidMount, so the listeners are undefined. Releasing the fix now, thanks!

[pietropizzi]

@alvaromb thanks!

[alvaromb]

Released https://github.com/APSL/react-native-keyboard-aware-scroll-view/releases/tag/v0.2.4

[alvaromb]

Hi @pietropizzi!

How do you feel about being a collaborator of this library? I have tons of work and other libraries to maintain and I would love to have some help here. Please feel free to ping me if you want to collaborate ☺️