(typescript) type scrollIntoView method #537
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @hduprat, you can use patch-package until they approve |
| I just ran into this issue. Without this PR, linters show an error if you try to use |
| Hi FYI I'm not maintaining this package. It just happened that I got merge/publish access and was the last one to do a release as a service to the community, but I have never been the project maintainer and don't plan to become one. If you want PRs to be reviewed/merged/published, it's best to contact the owners of this repo |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed the
scrollIntoViewmethod ofKeyboardAwareScrollViewwas not typed in Typescript. I added it, using native Typescript Types from React Native in order to ensure compatibility.It's a slightly more complete version than #378 that should have been merged back in 2019.