Skip to content

Support inverted lists #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Support inverted lists #367

wants to merge 2 commits into from

Conversation

thessler27
Copy link

@thessler27 thessler27 commented Jun 26, 2019 •
edited
Loading

This allows for inverted lists to be supported by flipping the contentInset prop config from bottom to top if a prop of inverted is passed.

Fixes #321
@thessler27 thessler27 closed this Jul 21, 2019
@vidit-bhatia
Copy link

was this ever merged?
manjuy124
manjuy124 reviewed Oct 14, 2020
View reviewed changes
lib/KeyboardAwareHOC.js

//support inverted views
const contentInset = this.props.inverted ?
{ bottom: this.state.keyboardSpace } :
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this have to be vice-versa like below!

const contentInset = this.props.inverted ?
{ top: this.state.keyboardSpace } :
{ bottom: this.state.keyboardSpace }
@manjuy124
Copy link

manjuy124 commented Oct 14, 2020 •
edited
Loading

@thessler27 any reason for closing this PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@thessler27 @vidit-bhatia @manjuy124