Security Fix: Prevent Private Key Leak in solanaRPC.ts #395
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Security Fix: Private Key Leak in Frontend Error Handling
Severity: Critical
Vulnerability Type: Information Exposure (CWE-532)
Description:
This Pull Request fixes a critical security vulnerability in
frontend/src/solanaRPC.ts. previously, thesendTokenmethod explicitly logged the user's raw, plaintext private key to the browser console (console.log) whenever a key length validation error occurred.Changes:
console.logstatement in the error handling block ofsendToken.stdoutor application logs.Testing:
tests/poc_key_leak.ts).