Skip to content

fix: add missing semicolon in AutoPublicPathRuntimeModule #16811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheLarkInn merged 2 commits into from
Mar 14, 2023
Merged

fix: add missing semicolon in AutoPublicPathRuntimeModule #16811

TheLarkInn merged 2 commits into from
Mar 14, 2023

Conversation

@snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 12, 2023

What kind of change does this PR introduce?
Fixes #15003

Did you add tests for your changes?
Updated snapshots.

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing
@webpack-bot
Copy link
Contributor

webpack-bot commented Mar 12, 2023

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)
@snitin315 snitin315 force-pushed the fix/add-missing-semicolon branch from fd3d2b2 to 976320d Compare March 14, 2023 13:16
@webpack-bot
Copy link
Contributor

webpack-bot commented Mar 14, 2023

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@alexander-akait Please review the new changes.
@snitin315
Copy link
Member Author

snitin315 commented Mar 14, 2023

Rebased and fixed conflicts.
TheLarkInn
TheLarkInn approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@TheLarkInn TheLarkInn merged commit be54e43 into webpack:main Mar 14, 2023
@TheLarkInn
Copy link
Member

TheLarkInn commented Mar 14, 2023

Nice fix! 🎉 💯
@snitin315 snitin315 deleted the fix/add-missing-semicolon branch March 15, 2023 01:05
@lasar lasar mentioned this pull request Mar 16, 2023
Merged
This was referenced Apr 7, 2023
Closed
Merged
@renovate renovate bot mentioned this pull request May 26, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: reviewed-approved

4 participants

@snitin315 @webpack-bot @TheLarkInn @alexander-akait