Skip to content

Friendly exception for invalid keys #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2021
Merged

Friendly exception for invalid keys #83

merged 2 commits into from
Jul 14, 2021

Conversation

GurGaller
Copy link
Contributor

Fixes issue #78
@GurGaller
Added a friendly exception for invalid encryption keys
e450226 
Also fixed a StackOverflow error in WebPushClient.SendNotification
@GurGaller
Merged remote master
da64e64
@GurGaller
Copy link
Contributor Author

Note the use of .GetAwaiter().GetResult() over .Result to capture any possible exceptions correctly. .Result will throw an AggregateException instead of the original exception.
@coryjthompson coryjthompson merged commit 77b04bd into web-push-libs:master Jul 14, 2021
@coryjthompson
Copy link
Member

This is excellent - thank you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@GurGaller @coryjthompson