chore: remove unnecessary lazyBarrel config #6373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the explicit lazyBarrel: true configuration from Rspack experiments since this feature has been enabled by default in Rspack v1.6.0-beta.0, making the manual configuration redundant.
- Removed
lazyBarrel: truefrom the experiments configuration in the basic plugin - Updated test snapshots to reflect the removal of the lazyBarrel configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/plugins/basic.ts | Removed the explicit lazyBarrel: true setting from Rspack experiments configuration |
| packages/core/tests/snapshots/basic.test.ts.snap | Updated snapshots to remove lazyBarrel from basic plugin test outputs |
| packages/core/tests/snapshots/builder.test.ts.snap | Updated snapshots to remove lazyBarrel from builder test outputs |
| packages/core/tests/snapshots/default.test.ts.snap | Updated snapshots to remove lazyBarrel from default plugin test outputs |
| packages/core/tests/snapshots/environments.test.ts.snap | Updated snapshots to remove lazyBarrel from environment configuration test outputs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
The
experiments.lazyBarrelconfig has been enabled by default in Rspack v1.6.0-beta.0, so it's no longer needed.Related Links
Checklist