Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Move helper functions into dedicated modules (fs, path, stats, vendors) to avoid importing helpers via barrel files.

This helps avoid occasional circular dependency issues when using Rstest.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
Copilot AI review requested due to automatic review settings October 5, 2025 01:39
@netlify
Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit f0ab25b
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68e23d9dacc9b600087982ec
😎 Deploy Preview https://deploy-preview-6309--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the helper functions organization by moving them from barrel file exports into dedicated modules (fs, path, stats, vendors) to avoid circular dependency issues when using Rstest.

  • Reorganized helper functions into dedicated modules instead of a single barrel export
  • Updated import statements across files to import from specific helper modules
  • Removed wildcard exports from the main helpers index file

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/core/src/helpers/index.ts Removed barrel exports and kept only core exports
packages/core/src/server/watchFiles.ts Updated imports to use specific helper modules
packages/core/src/server/socketServer.ts Changed import to use vendors helper module
packages/core/src/server/proxy.ts Updated requireCompiledPackage import path
packages/core/src/server/prodServer.ts Split imports between path and vendors helpers
packages/core/src/server/overlay.ts Updated toRelativePath import to path helper
packages/core/src/server/middlewares.ts Split imports between main helpers and stats
packages/core/src/server/helper.ts Updated getCommonParentPath import to path helper
packages/core/src/server/devServer.ts Separated vendor helper imports
packages/core/src/server/devMiddlewares.ts Updated requireCompiledPackage import path
packages/core/src/server/browserLogs.ts Split imports between main helpers and vendors
packages/core/src/server/assets-middleware/setupOutputFileSystem.ts Updated requireCompiledPackage import path
packages/core/src/server/assets-middleware/middleware.ts Updated requireCompiledPackage import path
packages/core/src/provider/initConfigs.ts Split imports between main helpers and path
packages/core/src/provider/helpers.ts Updated stats helper exports
packages/core/src/provider/createCompiler.ts Separated stats helper imports
packages/core/src/plugins/server.ts Updated dedupeNestedPaths import to path helper
packages/core/src/plugins/manifest.ts Updated requireCompiledPackage import path
packages/core/src/plugins/html.ts Updated isFileExists import to fs helper
packages/core/src/plugins/fileSize.ts Split imports between main helpers and stats
packages/core/src/plugins/cleanOutput.ts Updated emptyDir import to fs helper
packages/core/src/plugins/cache.ts Split imports between main helpers and fs
packages/core/src/plugins/bundleAnalyzer.ts Updated requireCompiledPackage import path
packages/core/src/plugins/appIcon.ts Split imports between main helpers, fs, and vendors
packages/core/src/pluginHelper.ts Updated requireCompiledPackage import path
packages/core/src/loader/transformLoader.ts Updated requireCompiledPackage import path
packages/core/src/loadEnv.ts Split imports between main helpers and fs
packages/core/src/defaultConfig.ts Split imports between main helpers and fs
packages/core/src/createRsbuild.ts Updated isEmptyDir import to fs helper
packages/core/src/cli/init.ts Split imports between main helpers and path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 4f5b166 into main Oct 6, 2025
11 checks passed
@chenjiahan chenjiahan deleted the helper_barrel_1005 branch October 6, 2025 09:01
@chenjiahan chenjiahan mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants