Document how to set global transaction id #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Mikemosca approved these changes Oct 30, 2020
Contributor
Mikemosca left a comment
Mikemosca left a comment There was a problem hiding this comment.
Hi, Just some minor feedback.
- Together the service instance region, this ID helps support teams troubleshoot issues from relevant logs.
The first part of this sentence "Together the service instance region," reads a bit funny to me.
- However, the transaction ID isn't available when the API doesn't return a response for some reason
Maybe a reword...
The transaction ID is not always available when the API call does not return a response.
- For those not familiar with a transaction ID, Do you think its worth giving an example of what a valid transaction ID looks like?
Contributor Author
| thanks for the comments Mike! I think we are trying to keep this messaging consistent across SDKs and this was approved messaging from Allen. We could revisit this in the future but wanted to get these instructions into the readme asap. For transaction ID, this can be any unique string the user wants to send. |
Contributor
| 🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request documents how to set the global transaction id