Skip to content

fix(router): hashchange not emitted in certain cases #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix(router): hashchange not emitted in certain cases #3637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e1773
fix: page changes reset the hash when with i18n
zonemeen Mar 6, 2024
631e441
correct fix
brc-dd Mar 6, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/client/app/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export function createRouter(
: link.href,
link.baseURI
)
const currentUrl = window.location
const currentUrl = new URL(window.location.href) // copy to keep old data
// only intercept inbound html links
if (
!e.ctrlKey &&
Expand Down Expand Up @@ -211,7 +211,12 @@ export function createRouter(
window.scrollTo(0, 0)
}
} else {
go(href)
go(href).then(() => {
// do after the route is changed so location.hash in theme code is the new hash
if (hash !== currentUrl.hash) {
window.dispatchEvent(new Event('hashchange'))
}
})
}
}
}
Expand Down