Skip to content

Test support for multiple versions of ESLint Stylistic #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 1, 2025
Merged

Test support for multiple versions of ESLint Stylistic #2884

merged 8 commits into from
Aug 1, 2025

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented Jul 31, 2025 •
edited
Loading

Follow-up to #2830 (comment).

@ST-DDT It would be great if you could have a look at this 🙂
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bdcd7f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@FloEdelmann FloEdelmann mentioned this pull request Jul 31, 2025
Merged
@FloEdelmann FloEdelmann force-pushed the stylistic branch 10 times, most recently from e45a2c2 to 7f48833 Compare July 31, 2025 11:49
@FloEdelmann FloEdelmann requested a review from Copilot July 31, 2025 11:53
Copilot

This comment was marked as resolved.

Sign in to view

@FloEdelmann FloEdelmann marked this pull request as ready for review July 31, 2025 11:58
@FloEdelmann FloEdelmann requested review from ota-meshi and waynzh July 31, 2025 11:58
ST-DDT
ST-DDT approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't tested this version in any projects though, to check whether this "breaks"/changes anything there.

eslint-plugin-vue supports quite a lot versions of stylistic. I probably would have dropped one or two of them...
waynzh
waynzh approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks you!
@waynzh waynzh merged commit fd6fc41 into master Aug 1, 2025
15 checks passed
@waynzh waynzh deleted the stylistic branch August 1, 2025 07:29
@github-actions github-actions bot mentioned this pull request Aug 1, 2025
Merged
@FloEdelmann
Copy link
Member Author

check whether this "breaks"/changes anything there

Since this introduces only an optional dependency with nearly all versions allowed, I think it should be fine.

supports quite a lot versions of stylistic. I probably would have dropped one or two of them

Yeah, we should definitely do that in the future, but I didn't want to introduce a (potentially) breaking change in this small PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@FloEdelmann @ST-DDT @waynzh