Skip to content

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 22, 2024

resolve #2580

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@ota-meshi ota-meshi force-pushed the feature/slot-name-casing branch from c6cc9dc to 7d65824 Compare November 27, 2024 08:07
@FloEdelmann FloEdelmann force-pushed the feature/slot-name-casing branch from 7d65824 to c5730a8 Compare November 27, 2024 08:37
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but I have a few minor suggestions.

waynzh and others added 2 commits November 27, 2024 16:54
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
@waynzh waynzh requested a review from FloEdelmann November 27, 2024 09:00
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@FloEdelmann FloEdelmann merged commit a270df8 into vuejs:master Nov 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants