Skip to content

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 16, 2024

resolve #2458

waynzh and others added 4 commits November 19, 2024 12:05
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 🙂

@FloEdelmann
Copy link
Member

The test failure is probably caused by an ESLint update, so no need to worry about this.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit bea53c0 into vuejs:master Nov 27, 2024
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants