Skip to content

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Nov 15, 2024

This PR adds shallowRef support to rule prefer-use-template-ref.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement! I have a few minor comments but they should be easy to resolve.

@ntnyq ntnyq requested a review from FloEdelmann November 17, 2024 11:39
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 🙂

@FloEdelmann
Copy link
Member

I'll merge this without @ota-meshi's review now to make conflict resolution possible in #2612. But feel free to comment on it afterwards!

@FloEdelmann FloEdelmann merged commit 4500389 into vuejs:master Nov 18, 2024
18 checks passed
Thomasan1999 added a commit to Thomasan1999/eslint-plugin-vue that referenced this pull request Nov 18, 2024
@ntnyq ntnyq deleted the fix/prefer-use-template-ref branch December 31, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants